[HttpKernel] Replace ArgumentValueResolverInterface by ValueResolverInterface #17362
+55
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
force-pushed
the
issue-17225/value-resolver
branch
from
73dacdc to
61c7a55
Compare
nicolas-grekas
approved these changes
Oct 18, 2022
wouterj
force-pushed
the
issue-17225/value-resolver
branch
from
61c7a55 to
b6bcc3d
Compare
|
Thanks Wouter for this fantastic contribution! While merging I did some tweaks as reported in the review: 262baba |
kaznovac
added a commit
to kaznovac/symfony-docs
that referenced
this pull request
Dec 2, 2022
The `array` return type is on purpose. See symfony#17362 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17225
I've also updated the example using a different example (one we use frequently in our projects). The issue with the current example is that it re-implements something that was already built-in, requiring all sorts of workarounds.
cc @nicolas-grekas